Prioritize using default templates from card over task #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: elronbandel <[email protected]>
yoavkatz
approved these changes
Feb 12, 2025
yoavkatz
approved these changes
Feb 12, 2025
Signed-off-by: elronbandel <[email protected]>
… into default-template-policy
yoavkatz
reviewed
Feb 12, 2025
| return self.card is not None and self.card.templates is not None and len(self.card.templates) > 0 | ||
|
|
||
| @property | ||
| def has_no_templates(self): |
There was a problem hiding this comment.
maybe 'user_specified_expicit_template' is a better name (of the negated option)
yoavkatz
reviewed
Feb 12, 2025
| "references_field": "answers", | ||
| "__description__": "lmms-evals default template for infovqa." | ||
| }, | ||
| "templates": [ |
There was a problem hiding this comment.
Maybe add this as a "template.qa.single_word_answer?"
There was a problem hiding this comment.
The whole point of it being that it is curated for this card specifically
There was a problem hiding this comment.
I think it's pretty generic instruction - but not critical.
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
… into default-template-policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.